conan-io / conan-package-tools

Conan Package Tools. Helps with massive package creation and CI integration (Travis CI, Appveyor...)
MIT License
166 stars 71 forks source link

Fix stable branch pattern regular expressions #558

Closed ghost closed 3 years ago

ghost commented 3 years ago

Changelog: (Fix): Fix regex patterns and move initialization to init() method

The first commit fixes the patterns by adding a . between the last character and the *.

The second commit moves the initialization of the stable_branch_pattern variable to the class' init method to reduce the code size and always assure an initialized value right from the start when the Packager is created. This change would also allow the use of multiple stable branch patterns when using the environment variable CONAN_STABLE_BRANCH_PATTERN.

All changes are backwards compatible.

Issue #557

uilianries commented 3 years ago

Thank you for your contribution. Just a new test to validate your main issue and we are good to merge.

ghost commented 3 years ago

It took a little longer than expected to add the tests. All tests were passing locally on Ubuntu 18.04 / Python 3.6. No idea why AppVeyor is failing, I thought it had been removed?

ghost commented 3 years ago

Is this an issue with how pull requests are configured in this project? I have multiple PRs that are already using GitHub actions in my fork. They are all failing in this repo because of the AppVeyor error.

uilianries commented 3 years ago

Weird error from Appveyor. Indeed we could move to Github Actions, or even to our internal Jenkins.