Fix stable branch pattern

conan-io / conan-package-tools

Conan Package Tools. Helps with massive package creation and CI integration (Travis CI, Appveyor...)

MIT License

165 stars 70 forks source link

Fix stable branch pattern #577

Closed dvirtz closed 2 years ago

dvirtz commented 3 years ago

Changelog: Fix: split stable_branch_pattern argument like is done for the env var

fixes #576

[x] Refer to the issue that supports this Pull Request.
[x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
[x] I've read the Contributing guide.
[x] I've followed the PEP8 style guides for Python code.

CLAassistant commented 3 years ago

All committers have signed the CLA.

ghost commented 3 years ago

Thanks for finding this. I totally forgot this way of setting the stable branch patterns in the unit tests.

uilianries commented 3 years ago

Thank you for your contribution

dvirtz commented 3 years ago

the build errors do not seem related to this PR

uilianries commented 2 years ago

Yes, it seems be broken. I'll take a look better, thanks for reporting.

uilianries commented 2 years ago

@dvirtz I just fixed develop branch. Please, solve the conflicts (accept your change), also, keep main$ as branch pattern, as Github now is using it by default.

uilianries commented 2 years ago

@dvirtz Thank you! We will release a new minor version this week with your changes.