conan-io / conan-package-tools

Conan Package Tools. Helps with massive package creation and CI integration (Travis CI, Appveyor...)
MIT License
165 stars 70 forks source link

CONAN_BASE_PROFILE_BUILD is incorrectly passed to docker #596

Closed jmarrec closed 1 year ago

jmarrec commented 2 years ago

Changelog: (Fix): This is a draft PR that is just a work in progress trying to pass CONAN_BASE_PROFILE_BUILD to docker

Note: This is a draft PR as it currently doesn't work and includes lots of print-debugging (some of which I don't even see in the logs). It is just meant to serve as a point of discussion on #595. It will either be cleaned up or closed.

A failing example of an actual run that uses this patched cpt can be found here: https://github.com/jmarrec/conan-openstudio-ruby/runs/4852398264?check_suite_focus=true

Actual changes without debug-printing: https://github.com/conan-io/conan-package-tools/compare/1fce6c3a42e27022fdeceac6614dfeea85b61f14

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

Croydon commented 1 year ago

Is this PR obsolete?

jmarrec commented 1 year ago

@Croydon Non functional rather, but the need is still here, though I've worked around it since then. I'm fine closing if no one has the bandwith to help out finish it though.

Croydon commented 1 year ago

I don't understand the issue currently, the CI logs got deleted in the meantime and the referenced issue closed as solved 🤔

jmarrec commented 1 year ago

Meh, let's assume it's fine. Closing then :)