conan-io / conan-package-tools

Conan Package Tools. Helps with massive package creation and CI integration (Travis CI, Appveyor...)
MIT License
165 stars 70 forks source link

Use user and channel of recipe if not specified #603

Open pgrohs opened 2 years ago

pgrohs commented 2 years ago

Changelog: (Feature): Capture username and channel from conanfile.py

Closes #602

In case user or channel are not given to ConanMultiPackager via parameter or environment variable, both are taken from the recipe to build. The overcomes the necessity to repeat user and channel of the recipe in the build script. Furthermore, it enables the realization of custom channel-strategies in the recipe.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

uilianries commented 2 years ago

@pgrohs Thank you for your contribution. Please, check those failed test. It seems like your feature broke some of them. Probably you need to validate case where user and channel are used, but they are None.

pgrohs commented 2 years ago

@uilianries I have updated the PR. Could please run the test cases?

uilianries commented 2 years ago

@pgrohs Sorry the delay. Starting it now

pgrohs commented 2 years ago

@uilianries Could you please try to run the CI pipeline again?