conan-io / conan-package-tools

Conan Package Tools. Helps with massive package creation and CI integration (Travis CI, Appveyor...)
MIT License
165 stars 70 forks source link

Feature/build profile #604

Closed sbannier closed 2 years ago

sbannier commented 2 years ago

Changelog: (Fix): When using Docker: only pass a build profile if it has been explicitly specified

By default the ´´´default´´´ profile has been used if no build profile was given while creating the ´´´ConanMultiPackager´´´ for Docker. This causes Conan to always be run with a build profile, which is different to how it is run when not using Docker. Conan also behaves differently for some use cases when a build profile is given.

This pull request also strips down the build profile text passed to the Docker container via environment variables to a bare minimum. The reason for this is explained in the commit message (this change can also be reverted if I missed something)

fixes #595

codecov-commenter commented 2 years ago

Codecov Report

Merging #604 (34c149c) into develop (28ae68d) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #604   +/-   ##
========================================
  Coverage    78.60%   78.60%           
========================================
  Files           43       43           
  Lines         5290     5291    +1     
========================================
+ Hits          4158     4159    +1     
  Misses        1132     1132           
Impacted Files Coverage Δ
cpt/packager.py 87.16% <100.00%> (+0.05%) :arrow_up:
cpt/profiles.py 91.37% <100.00%> (-0.15%) :arrow_down:
cpt/ci_manager.py 92.46% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.