Bugfix: Replace startswith assert with a more general "in" on checking LDFLAGS

conan-io / conan

Conan - The open-source C and C++ package manager

https://conan.io

MIT License

8.17k stars 974 forks source link

Bugfix: Replace startswith assert with a more general "in" on checking LDFLAGS #16409

Closed perseoGI closed 3 months ago

perseoGI commented 4 months ago

Changelog: Omit Docs: omit

[ ] Refer to the issue that supports this Pull Request.
[ ] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
[x] I've read the Contributing guide.
[x] I've followed the PEP8 style guides for Python code.
[ ] I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

perseoGI commented 4 months ago

The tests get the env from the parent scope. I tried cleaning it but quite a few tests started failing, this is a good patch for now until we think a bit more about it

Yes, definetly tests should not depend on user shell environment. This is just a quick bugfix but we should really change the tests behaviour!