[bug] XcodeToolchain's conan_global_flags.xcconfig not flagged to save if _global_defines is populated

conan-io / conan

Conan - The open-source C and C++ package manager

https://conan.io

MIT License

7.97k stars 952 forks source link

[bug] XcodeToolchain's conan_global_flags.xcconfig not flagged to save if _global_defines is populated #16422

Closed jacobfriedman closed 3 weeks ago

jacobfriedman commented 1 month ago

Describe the bug

Changelog: (Bugfix):

Docs state that the global xcode config will be generated with modification of the _global_defines, but the _check_if_extra_flags(self) only checks for cflags/cxxflags/ldflags/exelinkflags.

Docs: https://docs.conan.io/2/reference/tools/apple/xcodetoolchain.html#xcodetoolchain-conf

How to reproduce it

Attempt to modify _global_defines and conan_global_flags.xcconfig will not be created.

Fix: https://github.com/jacobfriedman/conan/pull/1

czoido commented 1 month ago

Hi @jacobfriedman, Thanks a lot for reporting. Indeed it seems a bug. Adding this to be fixed in the 2.5.0 release.

memsharded commented 3 weeks ago

Closed by https://github.com/conan-io/conan/pull/16429 for 2.5