search

conan-io / conan

Conan - The open-source C and C++ package manager
https://conan.io
MIT License
7.96k stars 952 forks source link

Ensure msvc cppstd compatibility fallback does not ignore 194 binaries #16573

Closed AbrilRBS closed 3 days ago

AbrilRBS commented 4 days ago

Changelog: Bugfix: Ensure msvc cppstd compatibility fallback does not ignore 194 binaries. Docs: Omit

This is one of the alternatives, another one might be to test each factor in isolation too?

Closes https://github.com/conan-io/conan/issues/16564

memsharded commented 4 days ago

This is one of the alternatives, another one might be to test each factor in isolation too?

Yes, I think the combinatorics is not complete, and the empty element of each factor should also be used for the combinations.

AbrilRBS commented 4 days ago

Good catch. I've changed the fix to address what I think the underlying issue is, can discuss it later :)