Closed X1aomu closed 6 days ago
Hi @X1aomu,
Thanks a lot for reporting and thank you for your kind words. Yes, there's a mismatch between the docs and changelog and the implementation, this should be corrected in the docs, so I'm transferring this issue to the Conan docs repo and will modify the release notes as well.
This has been closed by https://github.com/conan-io/docs/pull/3903, thanks again for your feedback!
Thank you all for quick fix :)
There's one more problem. Ingenerate()
function, simply calling self.generator_info.append(MyGenerator)
will fail. I don't know whether it is expected to work or not. If not, we should replace it with self.generator_info = [MyGenerator]
.
What is your question?
I'm trying to migrate my custom generators to the tool_require style, which is an awesome feaature I think💗️ :)
But I noticed that the example given in docs dosen't work at all.
The docs says:
But:
generators_info
is actuallygenerator_info
append(MyGenerator)
will cause exception asgenerator_info
is initialize to beNone,
not an arrayWhat's more, the release note says:
The question is, which side should have a fix, the docs or the code?
These are related PRs:
Have you read the CONTRIBUTING guide?