search

conan-io / examples

Conan 1.x examples
MIT License
124 stars 66 forks source link

Fixed 'if' syntax error in bat. #88

Open zhangyiant opened 3 years ago

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

memsharded commented 3 years ago

Thanks for contributing. The CI has an error, doesn't seem related to your PR.

FYI, the workspace is a experimental feature that has been on hold for a long time, as we are working in other priorities, so there will be rough edges and expect partial functionality.

Can you clarify if this change is necessary, was it really broken or it is just style?

zhangyiant commented 3 years ago

Thanks for contributing. The CI has an error, doesn't seem related to your PR.

FYI, the workspace is a experimental feature that has been on hold for a long time, as we are working in other priorities, so there will be rough edges and expect partial functionality.

Can you clarify if this change is necessary, was it really broken or it is just style?

It's really broken. The "else" in build.bat cannot work if it's on a separate line, but the script will continue to run. So it has almost no impact. Anyway, it's a bug in the script, so fix it incidentally.

czoido commented 3 years ago

@memsharded, @zhangyiant I have just fixed the CI error for the MacOs node, looks like the CI it's working now again.