conan-io / examples2

Conan 2.x examples
MIT License
87 stars 48 forks source link

quote is missed in command for imgui example #133

Closed FreePhoenix888 closed 6 months ago

FreePhoenix888 commented 6 months ago

Actual

cmake . -G "Visual Studio 17 2022"
-DCMAKE_TOOLCHAIN_FILE=./build/generators/conan_toolchain.cmake
-DCMAKE_POLICY_DEFAULT_CMP0091=NEW'

Expected

cmake . -G "Visual Studio 17 2022"
-DCMAKE_TOOLCHAIN_FILE=./build/generators/conan_toolchain.cmake
-DCMAKE_POLICY_DEFAULT_CMP0091='NEW'
czoido commented 6 months ago

Hi @FreePhoenix888,

Thanks for reporting, we will remove the extra single quote there.

czoido commented 6 months ago

Thanks for reporting, the issue is now fixed: https://github.com/conan-io/conan-io.github.io/pull/261