search

conan-io / examples2

Conan 2.x examples
MIT License
89 stars 49 forks source link

use tool_requires in build_requirements method #77

Closed dornbirndevelops closed 1 year ago

dornbirndevelops commented 1 year ago

according to the documentation, tool_requires usage should be in build_requirements method

dornbirndevelops commented 1 year ago

docs were also updated https://github.com/conan-io/docs/pull/3025

dornbirndevelops commented 1 year ago

nevermind. just saw in the documentation that tool_requires and test_requires can also be used in the requirements method.

memsharded commented 1 year ago

Yes, it can go in 2.0 in requirements() method too, those 2 functions are executed sequentially.

However I think it would be cleaner if it is in build_requirements() instead, that is recommended, I'd suggest re-opening and letting @czoido who wrote this part decide, maybe it was intentioned, maybe not.

czoido commented 1 year ago

Yes, I think we can reopen, this is a mistake and was not intentional, and I will have a look at the docs and this repo if we have to change any more. Thanks a lot @dornbirndevelops for reporting