Closed uilianries closed 2 years ago
I'd say 89 recipes is not that much and in any case, the fix is pretty straightforward. Let's see what others think about it
Changed the rule a little, now all four values os
, arch
, compiler
, build_type
are required on settings
, otherwise, it will rise a warning message.
I think we can turn it into an error, there are not so many recipes (report should arrive soon 😉 )
I think we can turn it into an error, there are not so many recipes (report should arrive soon 😉 )
Hell yeah 😈
2022-03-15
Hook validation run successfully for 3155 references :tada:
*/master
)Looking forward to those fixes! Thanks!
Turn them to errors, only 5 references (2 recipes) are failing.
I don't know how this number was generated, but it does not follow the reality. This hook checks if settings
attribute is declared, and os
, arch
, compiler
and build_type
are listed. Doing a quick view, there are 89 recipes without settings
on CCI, and didn't count how many are missing settings values (header-only usually only carry compiler
due cpp support). In case we switch it to error level, will be a disaster, probably more than 100 broken recipes.
It is directly the output from the ScheculedExportCheck job
🤦 ... and it is a warning so they are not failing. Shame on me!
I would love to convert it to an error message, but doing a check, we have 89 recipes without settings on conan center index.
closes #371