- conandata.yml reduce hook for 2.0

conan-io / hooks

Official Conan client hooks

MIT License

32 stars 46 forks source link

- conandata.yml reduce hook for 2.0 #429

Closed SSE4 closed 2 years ago

SSE4 commented 2 years ago

generates the same RREV as v1:

fmt/8.1.1: Exported revision: f0c7ec2a07a4a1ba80bfc2e4cbf18a43

f0c7ec2a07a4a1ba80bfc2e4cbf18a43

with v2:

←[1m←[32mExported recipe: fmt/8.1.1#f0c7ec2a07a4a1ba80bfc2e4cbf18a43 (2022-06-22 11:12:33 UTC)←[0m

uilianries commented 2 years ago

Is it not the same as "KB-H031": "CONANDATA.YML REDUCE"?

SSE4 commented 2 years ago

Is it not the same as "KB-H031": "CONANDATA.YML REDUCE"?

it is the same, plus some minor changes for 2.0 api. right now it's faster/easier to extract it to its own hook, instead of migrating the whole file (which I doubt we will need, as most of checks could be moved to linter).

uilianries commented 2 years ago

@SSE4 sounds reasonable. Please, update the README too.

SSE4 commented 2 years ago

@SSE4 sounds reasonable. Please, update the README too.

what exactly?

uilianries commented 2 years ago

@SSE4 sounds reasonable. Please, update the README too.

what exactly?

Add this new hook to its index with a small description like others.

danimtb commented 2 years ago

I think it is fine to have it separated from the rest of hooks. This way we can clearly know what hooks conan v2 would use. In the mid term, as we start to add some more hooks here, we would have to add tests for them as well.