conan-io / hooks

Official Conan client hooks
MIT License
32 stars 46 forks source link

Skip post package for static library when building header only #457

Closed uilianries closed 1 year ago

uilianries commented 1 year ago

fixes #456

/cc @toge

SpaceIm commented 1 year ago

Should this logic also be added to _shared_files_well_managed()?

SpaceIm commented 1 year ago

I think this PR should be reverted. Hook behaved properly in https://github.com/conan-io/conan-center-index/pull/14330 (https://github.com/conan-io/hooks/issues/456), miniaudio recipe was not removing shared option in configure() when header_only option was True.