search

conan-io / hooks

Official Conan client hooks
MIT License
32 stars 44 forks source link

Fix a `self.options.remove()` false positive #511

Closed valgur closed 10 months ago

valgur commented 10 months ago

Triggered in https://github.com/conan-io/conan-center-index/pull/19381#issuecomment-1691437774 for self.options.remove_deprecations.

valgur commented 10 months ago

Could someone hit "merge" as well, please? :smile:

uilianries commented 10 months ago

@valgur Need to fix tests first. It seems be a networking error, I'll take a look.

uilianries commented 10 months ago

~I gonna merge it manually~. After checking logs, it's related to PyYAML

EDIT:

I can't merge it manually, no permission 😞

uilianries commented 10 months ago

@valgur There is a hotfix available in master branch. Could you please rebase your branch, so it should work now.

valgur commented 10 months ago

@uilianries Done. The checks are green now.