conao3 / leaf.el

Flexible, declarative, and modern init.el package configuration
GNU General Public License v3.0
505 stars 28 forks source link

leaf-key-bind-keymap's argument PKG can accept a quoted list. And fix… #510

Closed ijah4 closed 3 years ago

ijah4 commented 3 years ago

… #506

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


noZ seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

conao3 commented 3 years ago

Why are you want to require multiple pkg?

ijah4 commented 3 years ago

If the user binds some commands/maps from several different packages. It is convenient to do it by leaf-keys. if not required any packages, just omit this argument.

conao3 commented 3 years ago

I have to require two packages for one keymap...? Do you have a concrete example?

ijah4 commented 3 years ago

For example:

(leaf-keys 
 ((package-k-map ("a" . map-from-package-a)
                 ("c" . map-from-package-c))
  (package-f-map ("b" . map-from-package-b)))
 nil 'bind-keymap '(package-a  package-b package-c))

There are 3 packages in here: package-a package-b package-c .
If I can specify BIND-KEYMAP-PKG to package-a package-b package-c to load them when binding.

I think it is a mistake this feature should belong to leaf-keys, rather than leaf-bind-key-map. so this PR is wrong.

ijah4 commented 3 years ago

I think we should close this PR. What do you think?

conao3 commented 3 years ago

OK, I close this.