Closed ijah4 closed 3 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Why are you want to require multiple pkg
?
If the user binds some commands/maps from several different packages. It is convenient to do it by leaf-keys
. if not required any packages, just omit this argument.
I have to require two packages for one keymap...? Do you have a concrete example?
For example:
(leaf-keys
((package-k-map ("a" . map-from-package-a)
("c" . map-from-package-c))
(package-f-map ("b" . map-from-package-b)))
nil 'bind-keymap '(package-a package-b package-c))
There are 3 packages in here: package-a
package-b
package-c
.
If I can specify BIND-KEYMAP-PKG to package-a
package-b
package-c
to load them when binding.
I think it is a mistake this feature should belong to leaf-keys
, rather than leaf-bind-key-map
.
so this PR is wrong.
I think we should close this PR. What do you think?
OK, I close this.
… #506