Complete the leaf-key[*]'s PREDICATE function.

conao3 / leaf.el

Flexible, declarative, and modern init.el package configuration

GNU General Public License v3.0

505 stars 28 forks source link

Complete the leaf-key[*]'s PREDICATE function. #511

Closed ijah4 closed 3 years ago

ijah4 commented 3 years ago

Add the predicate function for leaf-key.

CLAassistant commented 3 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

noZ seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

conao3 commented 3 years ago

Thanks for pointing out this! This is just a question, but when would I use this feature? Anyway, it was not a good thing that what was written in the description was not implemented.

(Just information, this feature in use-package via https://github.com/jwiegley/use-package/commit/747c75a033409a371bab92861fb23c60a9462d2a )

ijah4 commented 3 years ago

I have no idea about this feature. yet I haven't used it. I think it may be forgot to implement, according to the docstring.

conao3 commented 3 years ago

Yes, it is a problem that the functionality described in the docstring is not implemented. However, since I don't know when we use this feature, I think it would be better to remove the corresponding description from the docstring.

ijah4 commented 3 years ago

Should this PR be closed?

conao3 commented 3 years ago

To be honest, I believe this feature is not useful so I want to just remove docstring relating this feature. Could you send PR?

ijah4 commented 3 years ago

In #515. I will fix the related docstring.