Open noamgal opened 8 years ago
+1
About your patch, it should be:
main_ver = int(django_version[0])
secondary_ver = int(django_version[1])
else, you get:
TypeError: int() argument must be a string or a number, not 'list'
@iankpconcentricsky I second that pull request
@iankpconcentricsky @Tsangares so, what is the status of this? isn't that urgent for django 1.10?
@noamgal Yes, it looks like there is another pull request #118. I could not get this django-tastypie-swagger to work sadly. Using pull #118, and #116, did not completely solve my issues. I do admit, I did not try very hard. But I was not eager to go debug someone else's code, I just started writing my own documentation because my api is small.
@noamgal Will try and find time to review this PR this week.
Linking #118 that covers this as well.
Any news on this?
+1
PR #121 should solve this
django.conf.urls.patterns() will be removed in Django1.10. https://docs.djangoproject.com/en/dev/internals/deprecation/#deprecation-removed-in-1-10
There are 2 pull requests to fix that: https://github.com/concentricsky/django-tastypie-swagger/pull/116 (mine , very defensively for django version) and https://github.com/concentricsky/django-tastypie-swagger/pull/115
@iankpconcentricsky - please approve one of them
Thanks