concentricsky / django-tastypie-swagger

An adapter to use swagger-ui with django-tastypie.
Other
132 stars 144 forks source link

Change urlpatterns to match Django1.10 #117

Open noamgal opened 8 years ago

noamgal commented 8 years ago

django.conf.urls.patterns() will be removed in Django1.10. https://docs.djangoproject.com/en/dev/internals/deprecation/#deprecation-removed-in-1-10

There are 2 pull requests to fix that: https://github.com/concentricsky/django-tastypie-swagger/pull/116 (mine , very defensively for django version) and https://github.com/concentricsky/django-tastypie-swagger/pull/115

@iankpconcentricsky - please approve one of them

Thanks

DarthLabonne commented 8 years ago

+1

DarthLabonne commented 8 years ago

About your patch, it should be:

main_ver = int(django_version[0])
secondary_ver = int(django_version[1])

else, you get:

TypeError: int() argument must be a string or a number, not 'list'
Tsangares commented 8 years ago

@iankpconcentricsky I second that pull request

noamgal commented 8 years ago

@iankpconcentricsky @Tsangares so, what is the status of this? isn't that urgent for django 1.10?

Tsangares commented 8 years ago

@noamgal Yes, it looks like there is another pull request #118. I could not get this django-tastypie-swagger to work sadly. Using pull #118, and #116, did not completely solve my issues. I do admit, I did not try very hard. But I was not eager to go debug someone else's code, I just started writing my own documentation because my api is small.

joshkehn commented 8 years ago

@noamgal Will try and find time to review this PR this week.

joshkehn commented 8 years ago

Linking #118 that covers this as well.

andrijan commented 8 years ago

Any news on this?

pg1671 commented 7 years ago

+1

AlSayedGamal commented 7 years ago

PR #121 should solve this