search

conceptualspace / yet-another-speed-dial

a modern speed dial for chrome, edge and firefox
Other
184 stars 33 forks source link

persistent storage for website logos #18

Closed deathtrip closed 3 years ago

deathtrip commented 3 years ago

Right now, when there's no internet connection, all the dials that use website logos are blank. Only the dials that use screenshots are normally displayed. I assume it's because YASD fetches the logos on every browser restart. I think a persistent storage would be a better solution, so dials are always visible regardless of internet connectivity status. It would also increase privacy, as less connections would be made.

conceptualspace commented 3 years ago

I've considered this too, but there are a few obstacles. And the most obvious question, if there is no internet connection, what am I doing in the browser?

The other consideration is that the local storage provided to extensions by chrome is really limited and slow. In testing I found it was actually faster (at least on my connection) to load the dials over the Internet than localstorage! And I sort of grew to like how some websites update their logos etc and YASD would pick that up automatically.

That said it would be worth another look because of the potential performance and privacy improvements. Thanks

deathtrip commented 3 years ago

Oftentimes i open my browser before my modem has established internet connectivity, and that's when the dials are blank, or when there's a temporary loss of connection. Currently a website can determine when a user opens their browser and how often, by looking at the connections being made. Maybe an option to enable local storage, so everyone can have it their preferred way.

conceptualspace commented 3 years ago

thats an interesting consideration. the main issue is the limitation of the storage api, where we are potentially limited to 5MB of total storage. maybe i could create an optimally compressed thumbnail for each site that is loaded while there's no network connection, giving us faster startup and a better experience for slower connections (PRs welcome!). i don't think there's any privacy concern here though -- if somebody has the means to monitor your network connections, no change to yasd is going to help.

conceptualspace commented 3 years ago

moving to backlog

SerafDosSantos commented 3 years ago

You could use the favicons, considering they are usually small, with an alternate default dial view.