search

conceptualspace / yet-another-speed-dial

a modern speed dial for chrome, edge and firefox
Other
184 stars 33 forks source link

Feature Request: resize site image to avoid clipping #22

Closed Cris70 closed 3 years ago

Cris70 commented 3 years ago

When site images are not square, the image is clipped. Sometimes it is clipped o bad that it is not recognizable anymore. It would be nice if you could automatically resize the image surface so that it is not clipped anymore.

conceptualspace commented 3 years ago

this was done intentionally (images use position:cover) to keep all the dials a consistent size. i just find it more aesthetic that way (indeed at the expense of occasional clipping -- for those sites i usually just select a better image).

i'll leave this issue open because a few users have asked for it, so maybe i'll add something like a "scale to fit" setting on the edit dial window. thanks for all your feedback @Cris70!

Omniains commented 3 years ago

this was done intentionally (images use position:cover) to keep all the dials a consistent size. i just find it more aesthetic that way (indeed at the expense of occasional clipping -- for those sites i usually just select a better image).

i'll leave this issue open because a few users have asked for it, so maybe i'll add something like a "scale to fit" setting on the edit dial window. thanks for all your feedback @Cris70!

So until this possible feature addition, what is the best/proper resolution to have the images at to fit the thumbnail without clipping? a 192x192 somewhat fits, this icon was ripped from the site it references, and scaling another down to 80x30 just bloats the image. this was from a screenshot that was a resolution of 198x74.

maybe the fix for this is to have a specified resolution for the thumbnails, and any image that is smaller than that, rather than it auto scailing to fit the speedial button, it centers it with an alpha layer? Not too sure how well that would work and sadly dont have the knowhow to test it haha.

conceptualspace commented 3 years ago

to answer your question @Omniains, the default tile ratio is currently 1.54:1, or 188x122 pixels. i might make this configurable in the future or have an option for 1:1.

the next release of YASD now has a "scale images" setting. it works by fitting the images to the tile, and fills the remaining space with a background color. this way we get a consistent grid but can still have variability in the image sizes

SerafDosSantos commented 3 years ago

I think that it's only a question of time until common websites make available a social media image along their content. Yes some dials look ugly, but most, not.