The duplication of the site title

HDark15 commented 3 years ago

In this case, I have a lot of sites who don't have the thumbnail after first sync to fresh Firefox. On the Firefox after sync the bookmarks from other devices, the extension start to open a lot of tabs from the speed dial bookmark. Like opening more than 50 tabs almost in the same time, but they close pretty fast. When opening the speed dial tab, a lot of the site has the same title and not get the thumbnail.

To change it back I need to open the Bookmarks Library, delete the name of the site one by one and it will be using the url. But on the Speed dial tab, it will just be an empty title. Trying to cut and paste to other folder outside speed dial and put it back. Doesn't change anything

conceptualspace commented 2 years ago

fixed in v1.15

conceptualspace commented 2 years ago

parallel processing of multiple bookmarks (as in case of sync/import) was overwriting global variable; reduced to local scope

HDark15 commented 2 years ago

The Firefox sync carried the error to the new profile Is there a way to reset it? Is it by re-installing the extensions?

conceptualspace commented 2 years ago

do you mean the bookmarks don't have the right titles? and just to confirm, you mean the titles were wrong on device A and then synced to device B, right? the bug that originally caused the problem should have been fixed in v1.15, so just want to make sure the sync isn't causing additional problems with the titles.

assuming that's correct, i have one idea to fix them up. if you're OK with using the URL as the title, we can easily run a function to assign the url as the title.

alternatively, YASD could loop through the bookmarks and fetch the tag from each site, the only downside being that it could take some time to run depending on how many bookmarks you have</p> <p>let me know what you think and i'll share further instructions on how to do it</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/HDark15"><img src="https://avatars.githubusercontent.com/u/34807171?v=4" />HDark15</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>do you mean the bookmarks don't have the right titles? and just to confirm, you mean the titles were wrong on device A and then synced to device B, right? </p> </blockquote> <p>Yes, thats right</p> <p>I have no problem with both of them. I will choose YASD so I can get proper title Can it fetch the thumbnail too? Cause all the thumbnail gone and it will be pain to click refresh thumbnail one by one</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/conceptualspace"><img src="https://avatars.githubusercontent.com/u/4175632?v=4" />conceptualspace</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>i'm going to push v2.1 to firefox shortly. then to update all your images: open the dev console (ctrl+shift+i) and type this: <code>refreshAllThumbnails()</code></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/conceptualspace"><img src="https://avatars.githubusercontent.com/u/4175632?v=4" />conceptualspace</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>@heywolf15 to update all your titles to match the URL, open YASD and paste this code into the dev console:</p> <pre><code>async function resetTitles() { console.log("updating titles to match urls...") const allFolders = folders.concat(speedDialId); for (let folder of allFolders) { let children = await browser.bookmarks.getChildren(folder); for (let child of children) { if (child.url && child.url.startsWith('http') && child.title !== child.url) { console.log(" >>> ", child.url) await browser.bookmarks.update(child.id, { title: child.url }); } } } console.log("done!") }</code></pre> <p>then just enter the command below and hit enter:</p> <p><code>resetTitles()</code></p> <p>that should do the trick :smile: </p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

conceptualspace / yet-another-speed-dial

The duplication of the site title #37