conceptualspace / yet-another-speed-dial

a modern speed dial for chrome, edge and firefox
Other
177 stars 32 forks source link

Add Github Action to Deploy to Web Stores #58

Closed ColdSauce closed 2 years ago

ColdSauce commented 2 years ago

Hey @conceptualspace, we made a Github action to make it easier to deploy to each of the web stores. This PR integrates YASD's browser extension to our Github action so you can deploy directly from the Github UI.

Currently supporting Chrome, Firefox, Edge, and Opera (Safari support coming soon too)

To facilitate this, I created a Makefile for the project and used jq to remove the keys not relevant to Chrome from the Chrome specific folder.

The only thing you would need to create is a SUBMIT_KEYS GitHub repository secret.

This secret is a JSON, with the schema defined here.

Here's a sample key (added the correct zip locations for chrome and firefox here):

{
  "$schema": "https://raw.githubusercontent.com/plasmo-corp/bpp/v1/keys.schema.json",
  "chrome": {
    "zip": "./chrome-extension.zip",
    "clientId": "123",
    "clientSecret": "456",
    "refreshToken": "789",
    "extId": "abcd"
  },
  "firefox": {
    "zip": "./firefox-extension.zip",
    "apiKey": "123",
    "apiSecret": "abcd",
    "extId": "foobar"
  }
}

You can find instructions on how to get those keys in the schema, or if you use vscode, the schema should provide hint/intelisense when hovering over the json properties. If you need any help in setting up the keys, feel free to @ me.

Otherwise, if this doesn't seem necessary, feel free to close the PR!

conceptualspace commented 2 years ago

nice @ColdSauce, thank you for the PR!

although i already have a local deployment pipeline (it just isn't checked into this repo) :face_in_clouds:

one thing that is a PITA is indeed the safari deployment. i would be curious to see that (not for this extension as safari isn't supported, but enhance-o-tron-for-plex would benefit :smile:)

ColdSauce commented 2 years ago

Awesome @conceptualspace. I think we're gonna spend the next week or two figuring out Safari deployment. Will send enhance-o-tron a PR when I get the chance.

Out of curiosity, is there anything else thats a PITA when it comes to building browser extensions? We really wanna build some more cool tooling after we figure out this deployment stuff.

Closing this PR as you stated it's not necessary for you!