search

concerto / concerto-frontend

Frontend JS code for Concerto
http://concerto-signage.org
Other
7 stars 5 forks source link

timezone has no data for null #45

Closed mfrederickson closed 9 years ago

mfrederickson commented 9 years ago

You're probably already aware of this... image

gbprz commented 9 years ago

Which time zone were you trying to set? I pushed some code to core Concerto last night to include the time zone string in the screen's setup.js. If those changes weren't pulled in, it might be giving you that error. Otherwise, it might be an issue with the time zone mapping from Rails strings to the momentjs available time zones.

gbprz commented 9 years ago

After talking it through with @augustf, he pointed out that the screen might not even have a time zone set after the db migration.that adds this column. It seems like the time is just displaying your local time without any time zone adjustments as a result. The error message is unpleasant though, so I can add a check for the absence of any time zone and just get the local time instead.

gbprz commented 9 years ago

This should now be fixed as of 97512be306acc4f8a18d1d57481c5c3c50499c7e and ada6c403109021a892b971341e6c5b3154e8fd4c