search

concerto / concerto-frontend

Frontend JS code for Concerto
http://concerto-signage.org
Other
7 stars 5 forks source link

Manually specify content name and constructor attributes when registering content types #8

Closed gbprz closed 9 years ago

gbprz commented 9 years ago

Also adds a grunt watch task to automatically vulcanize the polymer elements for a better development workflow.

6

augustf commented 9 years ago

I don't really think having the specify the content type for registration is a big problem. Any notion of this being super DRY went away with having to have a file for each type (there's no sort of auto-generation going on), so having to specify the type name in the file is minor.

While it's not ideal to have to have a file for each type, if that's what we're doing, this just isn't a problem.

bamnet commented 9 years ago

P.S. Be on the lookout for whitespace, newline, and blank line changes. There are a few throughout this pull request.