search

concerto / concerto-signage.org

Jekyll site powering the Concerto public website.
https://www.concerto-signage.org/
Apache License 2.0
0 stars 1 forks source link

concerto "free download" button shows PHP code #19

Closed ddbruce closed 10 years ago

kench commented 10 years ago

Can you provide some steps to reproduce this?

Are you talking about the live http://concerto-signage.org website right now?

On a side note, this guide by Simon Tatham (of PuTTY fame) is a good resource about filing bug reports. :)

ddbruce commented 10 years ago

Steps to reproduce:

  1. Visit http://concerto-signage.org
  2. Look at the Concerto "free download" button.
  3. Notice that the code graphic shows the function isset(), hence PHP code.
  4. ???
  5. Profit
bamnet commented 10 years ago

Yea, we're currently serving the V2 code from the V1 site, which explains why there is some PHP code visible in this image: http://www.concerto-signage.org/assets/dl_icon.png. I suspect we won't fix this in the old site, but should make sure the new site is more up to date and doesn't show any php.

bamnet commented 10 years ago

So it looks like this is fixed. I'm not sure this change was worth it given the firefighting efforts to bring the site back online after such a small change.

augustf commented 10 years ago

Not even a little...not even at all.

ddbruce commented 10 years ago

image

augustf commented 10 years ago

@bamnet didn't mean to suggest that the site was working right, but this issue as such is "fixed."

bamnet commented 10 years ago

ACK. In the future, lets track outages via email. Github doesn't provide any sense of urgency (aka I don't read it often).

kench commented 10 years ago

Do we have a contact email address/emergency email alias for these kinds of situations?

bamnet commented 10 years ago

team@c-s.org has some folks with login credentials to fix things.