conchyliculture / wikipoff

Offline wikipedia android browser
GNU General Public License v3.0
14 stars 4 forks source link

Allow the app to use external SD cards to store wiki databases #11

Closed logomancer closed 9 years ago

logomancer commented 10 years ago

I have the English wiki on my tablet's SD card because there's more space there than the internal storage. However, WikipOff doesn't check there for databases. It would be nice if there was a way to designate a different directory for wikis.

conchyliculture commented 10 years ago

App is supposed to select only "external" storage. Unfortunately certain devices report internal storage as "external". I've already built a beta release: https://github.com/conchyliculture/wikipoff/releases/tag/beta1 where you can select the device for storage, but I can't test it (the app on AVD emulated devices always use the sdcard). Shouldn't crash too much, but I'd advise you to cleanly uninstall your current version & its data before insalling that release =)

nikonakoneko commented 10 years ago

Crash here when tapping on "Settings"

lolcat https://gist.github.com/c720c6f7a83d69c36f78

conchyliculture commented 10 years ago

hehe "lolcat". I've made some changes, still can't test on a devices that has multiple "external storages". New build is here: https://github.com/conchyliculture/wikipoff/releases/tag/beta2 Could you try it?

nikonakoneko commented 10 years ago

It doesn't crash anymore, but it shows internal SD card as the only option but I don't see anything abnormal in the logs.

I have a few xposed modules to force usage of /extSdCard I don't know if they may conflict with your settings though.

conchyliculture commented 10 years ago

shoot... Could you send me the result of a cat /proc/mount from the adb shell?

nikonakoneko commented 10 years ago

/proc/mounts

rootfs / rootfs ro,relatime 0 0
tmpfs /dev tmpfs rw,seclabel,nosuid,relatime,mode=755 0 0
devpts /dev/pts devpts rw,seclabel,relatime,mode=600 0 0
none /dev/cpuctl cgroup rw,relatime,cpu 0 0
proc /proc proc rw,relatime 0 0
sysfs /sys sysfs rw,seclabel,relatime 0 0
selinuxfs /sys/fs/selinux selinuxfs rw,relatime 0 0
debugfs /sys/kernel/debug debugfs rw,relatime 0 0
none /sys/fs/cgroup tmpfs rw,seclabel,relatime,mode=750,gid=1000 0 0
none /acct cgroup rw,relatime,cpuacct 0 0
tmpfs /mnt/asec tmpfs rw,seclabel,relatime,mode=755,gid=1000 0 0
tmpfs /mnt/obb tmpfs rw,seclabel,relatime,mode=755,gid=1000 0 0
tmpfs /mnt/fuse tmpfs rw,seclabel,relatime,mode=775,gid=1000 0 0
/dev/block/platform/msm_sdcc.1/by-name/system /system ext4 ro,seclabel,nosuid,nodev,relatime,data=ordered 0 0
/dev/block/platform/msm_sdcc.1/by-name/userdata /data ext4 rw,seclabel,nosuid,nodev,relatime,noauto_da_alloc,data=ordered 0 0
tmpfs /data/qcks tmpfs rw,seclabel,relatime,size=20480k,mode=750,gid=1000 0 0
/dev/block/platform/msm_sdcc.1/by-name/cache /cache ext4 rw,seclabel,nosuid,nodev,relatime,data=ordered 0 0
/dev/block/platform/msm_sdcc.1/by-name/persist /persist ext4 rw,seclabel,nosuid,nodev,relatime,data=ordered 0 0
/dev/block/platform/msm_sdcc.1/by-name/modem /firmware vfat ro,relatime,uid=1000,gid=1000,fmask=0337,dmask=0227,codepage=cp437,iocharset=iso8859-1,shortname=lower,errors=remount-ro 0 0
/dev/block/dm-0 /mnt/asec/com.speedsoftware.rootexplorer-2 ext4 ro,dirsync,seclabel,nosuid,nodev,noatime 0 0
/dev/block/dm-1 /mnt/asec/com.shazam.encore.android-2 ext4 ro,dirsync,seclabel,nosuid,nodev,noatime 0 0
/dev/block/dm-2 /mnt/asec/com.keramidas.TitaniumBackupPro-1 ext4 ro,dirsync,seclabel,nosuid,nodev,noatime 0 0
/dev/block/vold/179:65 /mnt/media_rw/sdcard1 fuseblk rw,dirsync,context=u:object_r:sdcard_external:s0,nosuid,nodev,noexec,noatime,user_id=0,group_id=0,allow_other,blksize=4096 0 0
/dev/fuse /storage/sdcard1 fuse rw,nosuid,nodev,relatime,user_id=1023,group_id=1023,default_permissions,allow_other 0 0
/dev/block/vold/179:29 /mnt/media_rw/sdcard0 ext4 rw,dirsync,context=u:object_r:sdcard_external:s0,nosuid,nodev,noexec,noatime,data=ordered 0 0
/dev/block/vold/179:29 /mnt/secure/asec ext4 rw,dirsync,context=u:object_r:sdcard_external:s0,nosuid,nodev,noexec,noatime,data=ordered 0 0
/dev/fuse /storage/sdcard0 fuse rw,nosuid,nodev,relatime,user_id=1023,group_id=1023,default_permissions,allow_other 0 0
/dev/block/dm-3 /mnt/asec/com.digia.Qt5Intro-1 ext4 ro,dirsync,seclabel,nosuid,nodev,noatime 0 0
/dev/block/dm-4 /mnt/asec/com.quoord.tapatalkxda.activity-1 ext4 ro,dirsync,seclabel,nosuid,nodev,noatime 0 0
jimktrains commented 10 years ago

I'm also having this issue with 0.2. I'll clone the repo and build the beta2 tag above.

conchyliculture commented 10 years ago

did you try https://github.com/conchyliculture/wikipoff/releases/tag/beta3 ?

Frenzie commented 10 years ago

Beta 3 seemed to be working after changing the storage location setting, but the download just disappeared into nothing after it finished, even though I could watch it grow in the file manager. I tested with the EU Wiki due to its comparatively modest size. However, if I download the file manually and put it in the right location it does work.

conchyliculture commented 9 years ago

Fixed as of release v0.3.0