search

conclave-team / conclave

CRDT and WebRTC based real-time, peer-to-peer, collaborative text editor
http://conclave.tech
MIT License
710 stars 130 forks source link

Adblock Plus can hide sharing link #17

Open ConnorKrammer opened 6 years ago

ConnorKrammer commented 6 years ago

When Adblock Plus has the "Block social media icons tracking" option enabled, it injects a stylesheet that, among other things, explicitly sets display: none !important on any element with the class .sharing-link. This causes the sharing link to be hidden in Conclave (and is really not Conclave's fault at all).

As far as I can tell, the class .sharing-link is only referenced once in the code base, to set display: inline-block—it might be worth changing the class name or targeting the element in another manner.

sunny-b commented 6 years ago

Thanks for bringing this to our attention. We should be able to change that class name easily enough. Will do so when I get some time.