conclave-team / conclave

CRDT and WebRTC based real-time, peer-to-peer, collaborative text editor
http://conclave.tech
MIT License
710 stars 130 forks source link

Firefox New Line bug #5

Closed sunny-b closed 6 years ago

sunny-b commented 6 years ago

This is probably related to #3

In Firefox, when editing on the same line, if a user types in a new line character, it isn't reflected on the other users screen and both users will be off by 1 line.

This is either due to either how CodeMirror acts in Firefox, as this is not an issue we see in Chrome or a bug in the updateRemoteCursors logic that is in the Editor class. That logic can be pretty tricky and finicky as there are many edge cases.

Will check it out if there is time, though anyone else is welcome to tackle it as well.