Closed kswenson closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.72%. Comparing base (
4eae95a
) to head (b4b022b
). Report is 28 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![]() |
![]() |
![]() |
![]() |
![]() |
Details:
chore: reduce cypress waits (#1363) | |||
Project: codap-v3 | Commit: 0ab7ede523 |
||
Status: Passed | Duration: 08:54 💡 | ||
Started: Jul 26, 2024 6:07 PM | Ended: Jul 26, 2024 6:16 PM |
View
Output
Test | Artifacts | |
---|---|---|
case table ui > table view > verify edit attribute properties with undo and redo |
Test Replay
Screenshots
|
View
Output
Test | Artifacts | |
---|---|---|
codap toolbar > will open a slider |
Test Replay
Screenshots
|
lgtm, and I'm all about reducing Cypress waits. I see some conflicts in the branch but otherwise good to go!
The
dragAttributeToTarget
command is used repeatedly throughout our cypress tests and specifies that it must wait for five seconds after each drop before continuing with the test. CODAP animations generally have two second durations, so even if a test requires waiting for animation to complete, 2.5 seconds should be plenty of time. This PR tests that hypothesis.