concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

chore: reduce cypress waits #1363

Closed kswenson closed 1 month ago

kswenson commented 1 month ago

The dragAttributeToTarget command is used repeatedly throughout our cypress tests and specifies that it must wait for five seconds after each drop before continuing with the test. CODAP animations generally have two second durations, so even if a test requires waiting for animation to complete, 2.5 seconds should be plenty of time. This PR tests that hypothesis.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.72%. Comparing base (4eae95a) to head (b4b022b). Report is 28 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1363 +/- ## ========================================== - Coverage 85.83% 85.72% -0.12% ========================================== Files 521 522 +1 Lines 25305 25582 +277 Branches 6897 6917 +20 ========================================== + Hits 21721 21930 +209 - Misses 3308 3377 +69 + Partials 276 275 -1 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1363/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1363/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.58% <ø> (-0.33%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1363/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.56% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 month ago

2 flaky tests on run #3854 ↗︎

0 200 29 0 Flakiness 2

Details:

chore: reduce cypress waits (#1363)
Project: codap-v3 Commit: 0ab7ede523
Status: Passed Duration: 08:54 💡
Started: Jul 26, 2024 6:07 PM Ended: Jul 26, 2024 6:16 PM
Flakiness  table.spec.ts • 1 flaky test View Output
Test Artifacts
case table ui > table view > verify edit attribute properties with undo and redo Test Replay Screenshots
Flakiness  toolbar.spec.ts • 1 flaky test View Output
Test Artifacts
codap toolbar > will open a slider Test Replay Screenshots

Review all test suite changes for PR #1363 ↗︎

nstclair-cc commented 1 month ago

lgtm, and I'm all about reducing Cypress waits. I see some conflicts in the branch but otherwise good to go!