concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

fix: collapsed case rows shouldn't show index menu [PT-187986400] #1364

Closed kswenson closed 1 month ago

kswenson commented 1 month ago

[PT-187986400]

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.63%. Comparing base (45afcf5) to head (7b11c98). Report is 14 commits behind head on main.

Files Patch % Lines
v3/src/components/case-table/use-index-column.tsx 95.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1364 +/- ## ========================================== - Coverage 85.80% 85.63% -0.18% ========================================== Files 518 519 +1 Lines 24908 25007 +99 Branches 6743 6781 +38 ========================================== + Hits 21373 21415 +42 - Misses 3266 3317 +51 - Partials 269 275 +6 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1364/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1364/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.94% <94.73%> (+0.08%)` | :arrow_up: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1364/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.16% <25.00%> (-0.54%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 month ago

3 flaky tests on run #3773 ↗︎

0 198 28 0 Flakiness 3

Details:

fix: collapsed case rows shouldn't show index menu [PT-187986400] (#1364)
Project: codap-v3 Commit: b39f8a92fe
Status: Passed Duration: 10:02 💡
Started: Jul 20, 2024 5:44 PM Ended: Jul 20, 2024 5:54 PM
Flakiness  table.spec.ts • 1 flaky test View Output
Test Artifacts
case table ui > table cell editing > edits cells Test Replay Screenshots
Flakiness  slider.spec.ts • 2 flaky tests View Output
Test Artifacts
Slider UI > updates variable name Test Replay Screenshots
Slider UI > adds new variable value Test Replay Screenshots

Review all test suite changes for PR #1364 ↗︎

kswenson commented 1 month ago

Pretty low test coverage, but otherwise looks good 👍

I added a test.