concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

187881303-informal-confidence-interval-v3 #1366

Closed bfinzer closed 1 month ago

bfinzer commented 1 month ago

[#187881303] Feature: An ICI url parameter allows the user to display an "informal confidence interval" on a box plot.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 52.55474% with 65 lines in your changes missing coverage. Please review.

Project coverage is 85.60%. Comparing base (b39f8a9) to head (8175111). Report is 44 commits behind head on main.

Files Patch % Lines
...measures/box-plot/box-plot-adornment-component.tsx 47.77% 47 Missing :warning:
...iate-measures/box-plot/box-plot-adornment-model.ts 46.66% 8 Missing :warning:
...sures/box-plot/box-plot-adornment-registration.tsx 60.00% 6 Missing :warning:
v3/src/utilities/math-utils.ts 71.42% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1366 +/- ## ========================================== - Coverage 85.75% 85.60% -0.15% ========================================== Files 519 519 Lines 25008 25114 +106 Branches 6355 6386 +31 ========================================== + Hits 21445 21499 +54 - Misses 3410 3462 +52 Partials 153 153 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1366/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1366/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.97% <51.87%> (-0.11%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1366/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `52.94% <2.91%> (-0.22%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 month ago

3 flaky tests on run #3844 ↗︎

0 201 28 0 Flakiness 3

Details:

187881303-informal-confidence-interval-v3 (#1366)
Project: codap-v3 Commit: b698ed1567
Status: Passed Duration: 09:58 💡
Started: Jul 25, 2024 10:41 PM Ended: Jul 25, 2024 10:51 PM
Flakiness  table.spec.ts • 1 flaky test View Output
Test Artifacts
case table ui > table view > verify edit attribute properties with undo and redo Test Replay Screenshots
Flakiness  graph.spec.ts • 1 flaky test View Output
Test Artifacts
Graph UI > graph view > tests creating graphs with undo/redo Test Replay Screenshots
Flakiness  slider.spec.ts • 1 flaky test View Output
Test Artifacts
Slider UI > updates variable name Test Replay Screenshots

Review all test suite changes for PR #1366 ↗︎