Closed pjanik closed 1 month ago
Attention: Patch coverage is 91.66667%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 85.73%. Comparing base (
08b3e9b
) to head (430e488
). Report is 10 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
v3/src/utilities/date-parser.ts | 91.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![]() |
![]() |
![]() |
![]() |
![]() |
Details:
Merge pull request #1367 from concord-consortium/187799270-extend-date-parser | |||
Project: codap-v3 | Commit: 56e85a3e52 |
||
Status: Failed | Duration: 10:15 💡 | ||
Started: Jul 23, 2024 11:38 AM | Ended: Jul 23, 2024 11:48 AM |
View
Output
Test | Artifacts | |
---|---|---|
Graph UI > graph inspector panel > change points in table and check for autoscale |
Test Replay
Screenshots
|
View
Output
Test | Artifacts | |
---|---|---|
case table ui > table cell editing > edits cells |
Test Replay
Screenshots
|
View
Output
Test | Artifacts | |
---|---|---|
codap toolbar > will open a slider |
Test Replay
Screenshots
|
While testing some edge cases, I've noticed that the existing V2 parser doesn't work well with years that have three digits. Since I rely on parseDate more than on V2, I wanted to fix that. Rather than modifying the existing regexp patterns, I've set things up in a way that allows us to gradually move to other date parsers in the future. Currently, I'm using the built-in Date.parse, but it's easy to replace it with something else.