concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

187994058 v3 DI horizontalScrollOffset #1369

Closed tealefristoe closed 1 month ago

tealefristoe commented 1 month ago

PT Story: https://www.pivotaltracker.com/story/show/187994058

This PR adds support for horizontalScrollOffset for case tables.

I was also able to remove a hack that was necessary with the old method of specifying tile order.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.71%. Comparing base (e2edec3) to head (d70a160). Report is 11 commits behind head on main.

Files Patch % Lines
v3/src/components/case-table/case-table.tsx 91.66% 1 Missing :warning:
...src/data-interactive/handlers/component-handler.ts 93.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1369 +/- ## ========================================== - Coverage 85.81% 85.71% -0.11% ========================================== Files 521 521 Lines 25210 25233 +23 Branches 6856 6865 +9 ========================================== - Hits 21635 21628 -7 + Misses 3421 3327 -94 - Partials 154 278 +124 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1369/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1369/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.87% <53.12%> (-0.17%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1369/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.42% <73.52%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 month ago

2 flaky tests on run #3822 ↗︎

0 201 28 0 Flakiness 2

Details:

187994058 v3 DI horizontalScrollOffset (#1369)
Project: codap-v3 Commit: 383f1b5cbf
Status: Passed Duration: 10:15 💡
Started: Jul 24, 2024 9:33 PM Ended: Jul 24, 2024 9:44 PM
Flakiness  table.spec.ts • 1 flaky test View Output
Test Artifacts
case table ui > table cell editing > edits cells Test Replay Screenshots
Flakiness  slider.spec.ts • 1 flaky test View Output
Test Artifacts
Slider UI > adds new variable value Test Replay Screenshots

Review all test suite changes for PR #1369 ↗︎