concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

187738935 v3 DI caseFormulaSearch #1372

Closed tealefristoe closed 1 month ago

tealefristoe commented 1 month ago

PT Story: https://www.pivotaltracker.com/story/show/187738935

This PR handles get caseFormulaSearch API requests. It uses the same engine used for attributes with formulas to parse and evaluate these requests.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.84%. Comparing base (7cdb8d9) to head (710bf18). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1372 +/- ## ========================================== + Coverage 85.52% 85.84% +0.31% ========================================== Files 521 521 Lines 25266 25335 +69 Branches 6449 6462 +13 ========================================== + Hits 21609 21748 +139 + Misses 3503 3433 -70 Partials 154 154 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1372/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1372/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.70% <2.43%> (+0.94%)` | :arrow_up: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1372/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.67% <100.00%> (+0.18%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 month ago

1 failed test on run #3832 ↗︎

1 200 28 0 Flakiness 0

Details:

187738935 v3 DI caseFormulaSearch (#1372)
Project: codap-v3 Commit: 6750b30d63
Status: Failed Duration: 10:19 💡
Started: Jul 25, 2024 12:46 AM Ended: Jul 25, 2024 12:56 AM
Failed  cypress/e2e/table.spec.ts • 1 failed test View Output
Test Artifacts
case table ui > table cell editing > edits cells Test Replay Screenshots

Review all test suite changes for PR #1372 ↗︎