concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

feat: implement `number` formula [PT-188007822] #1373

Closed pjanik closed 1 month ago

pjanik commented 1 month ago

https://www.pivotaltracker.com/story/show/188007822

The custom implementation of the number formula was missing, and it will be useful for Joe in his work on the CODAP plugins.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.83%. Comparing base (30cd1c4) to head (4eae95a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 187950451-mathjs-update #1373 +/- ## =========================================================== + Coverage 83.03% 85.83% +2.80% =========================================================== Files 521 521 Lines 25281 25305 +24 Branches 6831 6897 +66 =========================================================== + Hits 20992 21721 +729 + Misses 3983 3308 -675 + Partials 306 276 -30 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1373/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1373/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.90% <45.00%> (+5.67%)` | :arrow_up: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1373/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.56% <100.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 month ago

Passing run #3838 ↗︎

0 201 28 0 Flakiness 0

Details:

Merge pull request #1373 from concord-consortium/188007822-number-formula
Project: codap-v3 Commit: 41696effe5
Status: Passed Duration: 44:13 💡
Started: Jul 25, 2024 11:48 AM Ended: Jul 25, 2024 12:32 PM

Review all test suite changes for PR #1373 ↗︎