concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

fix: parsing of inequality operators in formulas #1377

Closed kswenson closed 1 month ago

kswenson commented 1 month ago

[PT-188009575]

We preprocess expressions to convert = to ==, but the regular expression used to do so needed to be more restrictive.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.64%. Comparing base (4eae95a) to head (ff4cf41). Report is 24 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1377 +/- ## ========================================== - Coverage 85.83% 85.64% -0.20% ========================================== Files 521 522 +1 Lines 25305 25582 +277 Branches 6897 6966 +69 ========================================== + Hits 21721 21909 +188 - Misses 3308 3519 +211 + Partials 276 154 -122 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1377/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1377/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.48% <100.00%> (-0.42%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1377/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.56% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 month ago

1 flaky test on run #3848 ↗︎

0 201 28 0 Flakiness 1

Details:

fix: parsing of inequality operators in formulas (#1377)
Project: codap-v3 Commit: 97101929ce
Status: Passed Duration: 09:40 💡
Started: Jul 26, 2024 2:27 AM Ended: Jul 26, 2024 2:37 AM
Flakiness  cypress/e2e/slider.spec.ts • 1 flaky test View Output
Test Artifacts
Slider UI > plays and pauses slider Test Replay Screenshots

Review all test suite changes for PR #1377 ↗︎