Closed kswenson closed 1 month ago
Attention: Patch coverage is 95.45455%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 85.72%. Comparing base (
f5d06d0
) to head (8133866
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...nts/graph/models/graph-data-configuration-model.ts | 94.73% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Project | codap-v3 |
Status | Passed |
Commit | fbdd6f9263 |
Started | Jul 30, 2024 12:26 AM |
Ended | Jul 30, 2024 12:35 AM |
Duration | 08:57 💡 |
OS | Linux Ubuntu - |
Browser | Chrome 126 ![]() |
![]() |
cypress/e2e/toolbar.spec.ts ![]() |
1 ![]() |
|
---|---|---|---|
1 | codap toolbar > will open a slider |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud
[PT-187833677]
The crash occurred on undoing the drop of a second (or more) Y attribute because
GraphDataConfigurationModel.filterCase
can get called for the "missing" attribute and crashed when it encountered anundefined
attribute description. Fixing that was straightforward, but revealed an underlying issue that the undo/redo of adding an additional y attribute still didn't work. The fix there was to add a MobX reaction to synchronize thefilteredCases
array with the attribute configuration. This meant that some bespoke code to manage that synchronization in response to particular events could be eliminated. The new reaction also relies on makingfilteredCases
a MobX shallow-observable array so that additions/removals to/from it can trigger the necessary reaction(s).