Closed tealefristoe closed 1 month ago
Attention: Patch coverage is 96.44670%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 85.83%. Comparing base (
181b8da
) to head (375f6d0
). Report is 32 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Project | codap-v3 |
Status | Passed |
Commit | 70fb260883 |
Started | Aug 6, 2024 3:45 PM |
Ended | Aug 6, 2024 3:55 PM |
Duration | 09:33 💡 |
OS | Linux Ubuntu - |
Browser | Multiple |
![]() |
cypress/e2e/toolbar.spec.ts ![]() |
1 ![]() |
|
---|---|---|---|
1 | codap toolbar > will open a graph |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud
@kswenson I got the jest tests working again on this PR so it's ready for another review.
I did make one additional change, which was to get rid of the setOptions
and setCreateOrShow
arguments to ComponentHandler.create()
, and instead allow a custom createOrShow
function and/or options
object to be included in a dictionary, along with the content
.
I didn't carefully check all changes made from the original PR, so I hope no problems snuck through. I think it would have been easier to manage these changes if the original PR was accepted and merged, and then the ComponentHandler
registration system was introduced in a separate PR. I think these changes were all improvements, it's just difficult to tell what changed when all the changes are stacked on top of each other.
PT Story: https://www.pivotaltracker.com/story/show/187738952
This PR adds support for most
get component
API requests. Types that remain unsupported have yet to be implemented in v3, most notably text and guide.A few tiles/components return more information than they did in v2:
globalValueName
andvalue
.captionAttributeName
,rightSplitAttributeName
,topSplitAttributeName
.dataContext
.Additionally, this PR makes
TileModel
derive fromV2Model
so tiles/components now have names, which can be useful in referencing them. That said, following v2, default tile names have limited utility: