search

concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

Fix Flaky Cypress Test for Slider Component #1382

Closed nstclair-cc closed 3 weeks ago

nstclair-cc commented 1 month ago

Pull Request: Fix Flaky Cypress Test for Slider Component

PT-188031351

Description: This PR addresses a flaky Cypress test related to the slider component. The test intermittently failed due to assertion errors caused by the slider component's shadow rendering with an effective width of 0. Changes include:

  1. Check Existence Before Visibility: Ensuring the component exists in the DOM before checking visibility.
  2. Check Internal Elements: Verifying visibility of internal elements within the slider component.

Please review and provide feedback. Thank you!

kswenson commented 3 weeks ago

Superseded by #1404.