Closed kswenson closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.75%. Comparing base (
f5d06d0
) to head (7c71737
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Project | codap-v3 |
Status | Passed |
Commit | b80596be7b |
Started | Jul 31, 2024 3:13 PM |
Ended | Jul 31, 2024 3:22 PM |
Duration | 09:10 💡 |
OS | Linux Ubuntu - |
Browser | Chrome 126 ![]() |
![]() |
toolbar.spec.ts ![]() |
1 ![]() |
|
---|---|---|---|
1 | codap toolbar > will open a graph | ||
![]() |
formula/formula-component.spec.ts ![]() |
1 ![]() |
|
1 | Formula Engine > Component Formula Tests > Formula in a new dataset |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud
[PT-187949371]
From the PT story:
Auto-scrolling during drag is the province of DndKit, which supports several auto-scroll configuration options described in DndKit #140. In particular, the
canScroll
callback function is used to indicate particular elements that should not be auto-scrolled. None of the existing configuration options make it possible to support auto-scroll in one dimension only rather than enabling/disabling scrolling for all dimensions.Therefore, we patch
@dnd-kit/core
to passdirection
information to thecanScroll
callback function so that clients can enable/disable scrolling in each dimension separately. In addition, we implement a registry of such callback functions so that individual tiles can register their individualcanScroll
callbacks. The table uses this to allow horizontal auto-scroll but prevent vertical auto-scroll of the case table component, and to disable auto-scroll of the table body (grid cells) in both directions since there's nothing droppable to scroll to in the grid.The
@dndkit/core
patch changes from this:in which the
canScroll
function is only passed the element, to: