cypress[bot]
commented
1 month ago
Test summary
Run details
| Project | codap-v3 |
| Status | Passed |
| Commit | 7d0e99bd30 |
| Started | Aug 5, 2024 5:59 PM |
| Ended | Aug 5, 2024 6:21 PM |
| Duration | 21:12 💡 |
| OS | Linux Ubuntu - |
| Browser | Chrome 127  |
Flakiness
|
formula/formula-component.spec.ts 
|
1 
|
|
|---|---|---|---|
| 1 | Formula Engine > Component Formula Tests > Formula in a new dataset | ||
|
|
cfm.spec.ts
|
1
|
|
| 1 | CloudFileManager > Opens a local document using different methods | ||
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud
codecov[bot]
PT Story: https://www.pivotaltracker.com/story/show/188045173
This PR addresses a bug that prevented new cases from being broadcast to other users when a new case was added to a shared table using the input row. The issue is that a notification was only being sent out when new case ids were encountered, but this wasn't being updated in some circumstances because
dataset.validateCases()was not being called. I'm still not sure why this wasn't being called in the context of a Collaborative shared table, but was in most other cases.The solution is to call
validateCases()indataset.addCases()after adding cases to the dataset. I'm not totally sure this is the right place to do it, since this function is called in many other places, but it seems to make sense to me that you'd want to update the cases after a new item is added. If we wanted to be precise about this call, it could be made inhandleRowsChangeinuse-rows.tsafter callingdata.addCases().