codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
Project coverage is 85.72%. Comparing base (
b80596b) to head (6ac805b). Report is 3 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| v3/src/v2/codap-v2-document.ts | 0.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1387 +/- ## ========================================== + Coverage 85.63% 85.72% +0.08% ========================================== Files 524 524 Lines 25690 25695 +5 Branches 6560 6562 +2 ========================================== + Hits 22000 22026 +26 + Misses 3535 3514 -21 Partials 155 155 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1387/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.67% <50.00%> (+0.09%)` | :arrow_up: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.43% <87.50%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
cypress[bot]
PT Story: https://www.pivotaltracker.com/story/show/188050066
This PR fixes a bug where sharing premade tables using the Collaborative plugin would result in tables losing all data. This was the result of the
cidproperty of attributes not being implemented in v3. Collaborative relies on matchingcidsto connect attributes between different users, setting thecidof attributes with matchingnameswhen first connecting. V3 was not updating thecidof these attributes properly, so the attributes were later not being matched, and Collaborative was ruthlessly deleting them as a result.The fix is to better support attribute
cidsin v3. The id is still used as thecidin most cases, unless:cidbe set.cidis set in a v2 document that is imported.