Closed tealefristoe closed 1 month ago
Attention: Patch coverage is 87.50000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 85.72%. Comparing base (
b80596b
) to head (6ac805b
). Report is 3 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
v3/src/v2/codap-v2-document.ts | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Project | codap-v3 |
Status | Passed |
Commit | 22797c0532 |
Started | Aug 2, 2024 1:12 AM |
Ended | Aug 2, 2024 1:20 AM |
Duration | 08:44 💡 |
OS | Linux Ubuntu - |
Browser | Chrome 126 ![]() |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud
PT Story: https://www.pivotaltracker.com/story/show/188050066
This PR fixes a bug where sharing premade tables using the Collaborative plugin would result in tables losing all data. This was the result of the
cid
property of attributes not being implemented in v3. Collaborative relies on matchingcids
to connect attributes between different users, setting thecid
of attributes with matchingnames
when first connecting. V3 was not updating thecid
of these attributes properly, so the attributes were later not being matched, and Collaborative was ruthlessly deleting them as a result.The fix is to better support attribute
cids
in v3. The id is still used as thecid
in most cases, unless:cid
be set.cid
is set in a v2 document that is imported.