Closed kswenson closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.76%. Comparing base (
181b8da
) to head (7a268f2
). Report is 32 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Project | codap-v3 |
Status | Passed |
Commit | 069eb2c91d |
Started | Aug 8, 2024 9:09 PM |
Ended | Aug 8, 2024 9:18 PM |
Duration | 09:07 💡 |
OS | Linux Ubuntu - |
Browser | Chrome 127 ![]() |
![]() |
cypress/e2e/toolbar.spec.ts ![]() |
2 ![]() |
|
---|---|---|---|
1 | codap toolbar > will open a slider | ||
2 | codap toolbar > will display a webpage |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud
While testing v3 with a spotty/nonexistent internet connection recently it became apparent that we weren't handling errors that occurred when loading the default plugins configuration using
fetch
correctly. This came to our attention recently as a source of flaky cypress tests as well. My first approach was a fairly small change to thePluginsButton
code to improve handling offetch
errors. This wasn't easy to write a jest test for, however, so I split out the fetching code to a newuseStandardPlugins()
custom hook and wrote a jest test for that. To test various possiblefetch
responses I installedjest-fetch-mock
(also used by CLUE). Then for good measure, I wrote a jest test for thePluginsButton
component as well.