Closed kswenson closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.79%. Comparing base (
70fb260
) to head (188046f
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Project | codap-v3 |
Status | Passed |
Commit | c86ce9dc92 |
Started | Aug 8, 2024 10:13 PM |
Ended | Aug 8, 2024 10:22 PM |
Duration | 09:06 💡 |
OS | Linux Ubuntu - |
Browser | Chrome 127 ![]() |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud
After the last round of
ComponentTitleBar
andgetTitle
refactoring, we ended up in a situation in which:CustomTitleBar
which passes agetTitle
prop toComponentTitleBar
.CustomTitleBar
component passes the same globalgetTitle
function as itsgetTitle
prop.The purpose of passing the
getTitle
function to theComponentTitleBar
originally was so thatCustomTitleBar
implementations could provide their own component-specific means of retrieving the title in a way that would allow the access of the title to occur in theComponentTitleBar
so that only it would re-render when the title changed. Once thegetTitle
customization moved from the component to the registration, there's no need for thegetTitle
prop at all. This allows components that don't require title bar customization, e.g. graph, map, and the upcoming text component (which is what got me here in the first place) to use the defaultComponentTitleBar
without customization.