concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

chore: simplify ToolShelf by moving undo/redo strings into component registration #1390

Closed kswenson closed 1 month ago

kswenson commented 1 month ago

Moving the undo/redo strings into the component registration allows us to eliminate component-specific code in the ToolShelf component.

Note: This PR is rooted on #1389, which should be merged first.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.74%. Comparing base (c86ce9d) to head (e753e43). Report is 1 commits behind head on main.

Files Patch % Lines
v3/src/components/tool-shelf/tool-shelf.tsx 40.00% 3 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (c86ce9d) and HEAD (e753e43). Click for more details.

HEAD has 5 uploads less than BASE | Flag | BASE (c86ce9d) | HEAD (e753e43) | |------|------|------| |cypress|5|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1390 +/- ## =========================================== - Coverage 85.71% 53.74% -31.98% =========================================== Files 526 520 -6 Lines 25837 25788 -49 Branches 7000 7049 +49 =========================================== - Hits 22147 13859 -8288 - Misses 3409 11773 +8364 + Partials 281 156 -125 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1390/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1390/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `?` | | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1390/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.74% <40.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 month ago



Test summary

200 0 29 0Flakiness 0


Run details

Project codap-v3
Status Passed
Commit 67b7a4154c
Started Aug 8, 2024 11:04 PM
Ended Aug 8, 2024 11:13 PM
Duration 09:09 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud