concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

feat: text component #1392

Closed kswenson closed 1 month ago

kswenson commented 1 month ago

[PT-181840926]

Adds basic text component functionality:

Still to do:

Some independent changes in service of this PR were submitted separately as #1389, #1390. This PR is rooted on those and should not be merged until those have been merged.

Along the way, several utilities were developed that may have use elsewhere. Some of them were developed for use in positioning the toolbar alongside the component but I ended up solving that problem another way, so in some cases these utilities are not used in this PR but I'm checking them in anyway on the grounds that they seem likely to be useful at some point.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 97.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.81%. Comparing base (e753e43) to head (e8445d2). Report is 2 commits behind head on main.

Files Patch % Lines
v3/src/components/container/container.tsx 88.88% 1 Missing :warning:
v3/src/hooks/use-codap-component-context.ts 80.00% 1 Missing :warning:
v3/src/hooks/use-component-wrapper-context.ts 80.00% 1 Missing :warning:
v3/src/models/codap/add-default-content.ts 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1392 +/- ## ========================================== - Coverage 85.83% 85.81% -0.02% ========================================== Files 526 533 +7 Lines 25838 25986 +148 Branches 7049 7026 -23 ========================================== + Hits 22177 22300 +123 + Misses 3506 3405 -101 - Partials 155 281 +126 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1392/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1392/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.45% <94.11%> (+<0.01%)` | :arrow_up: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1392/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.78% <52.22%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 month ago



Test summary

203 0 29 0Flakiness 0


Run details

Project codap-v3
Status Passed
Commit 696ce01760
Started Aug 9, 2024 6:15 AM
Ended Aug 9, 2024 6:24 AM
Duration 09:02 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud