concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

feat: delete formula retaining values #1394

Closed kswenson closed 1 month ago

kswenson commented 1 month ago

[PT-181889964]

@pjanik actually did the heavy lifting here, having implemented the desired behavior of preserving values on removing a formula in the engine. This PR just enables it in the UI. While in the code for handling the column header menu items I made a few other changes:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.92%. Comparing base (696ce01) to head (6aa75ce). Report is 1 commits behind head on main.

Files Patch % Lines
.../case-table/attribute-menu/attribute-menu-list.tsx 96.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1394 +/- ## ======================================= Coverage 85.92% 85.92% ======================================= Files 533 533 Lines 25986 25988 +2 Branches 7084 7091 +7 ======================================= + Hits 22329 22331 +2 + Misses 3379 3378 -1 - Partials 278 279 +1 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1394/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1394/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.62% <95.83%> (+0.03%)` | :arrow_up: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1394/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.79% <54.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 month ago



Test summary

204 0 29 0Flakiness 0


Run details

Project codap-v3
Status Passed
Commit aafdac8461
Started Aug 11, 2024 11:09 PM
Ended Aug 11, 2024 11:18 PM
Duration 09:10 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud