concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

fix: recalculate formulas on initial load of document #1395

Closed kswenson closed 1 month ago

kswenson commented 1 month ago

[PT-188095695]

The fix is to initialize the formula adapters later in the document creation process.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.92%. Comparing base (696ce01) to head (ac01d43). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1395 +/- ## ======================================= Coverage 85.92% 85.92% ======================================= Files 533 533 Lines 25986 25986 Branches 7084 7084 ======================================= Hits 22329 22329 Misses 3379 3379 Partials 278 278 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1395/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1395/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.58% <100.00%> (ø)` | | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1395/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.78% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 month ago



Test summary

204 0 29 0Flakiness 0


Run details

Project codap-v3
Status Passed
Commit 1062413e07
Started Aug 12, 2024 9:34 PM
Ended Aug 12, 2024 9:43 PM
Duration 09:10 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud