Closed tealefristoe closed 4 weeks ago
Attention: Patch coverage is 97.50000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 85.93%. Comparing base (
81c2675
) to head (6d41262
). Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
v3/src/models/data/data-set.ts | 97.22% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Project | codap-v3 |
Status | Passed |
Commit | 0ec29dfc56 |
Started | Aug 14, 2024 12:19 AM |
Ended | Aug 14, 2024 12:28 AM |
Duration | 08:44 💡 |
OS | Linux Ubuntu - |
Browser | Chrome 127 ![]() |
![]() |
cypress/e2e/text.spec.ts ![]() |
1 ![]() |
|
---|---|---|---|
1 | Text tile > updates text title with undo/redo |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud
PT Story: https://www.pivotaltracker.com/story/show/187178550
This PR improves the efficiency of the
notify itemSearch itemOrder
API request by adding a newdataset.moveItems
action that rearranges the order of items without removing them and then re-adding them.As a step towards this solution, I also improved the efficiency of
dataset.removeCases
, changing it from O(n^2) to O(n*log(n)). Even though the API request no longer uses this action, it still seemed worth keeping the improvement for other cases where it's used.I tested all three variants with tables shared between three users with approximately 5000 items. Here are the results:
removeCases
) - 1200-1500 msremoveCases
- 850-1000 msmoveItems
- 650-800 ms